On Wed, Feb 27, 2019 at 03:30:05PM +1100, Suraj Jitindar Singh wrote: > Add spapr_cap SPAPR_CAP_LARGE_DECREMENTER to be used to control the > availability of the large decrementer for a guest. > > Signed-off-by: Suraj Jitindar Singh <sjitindarsi...@gmail.com>
This series looks good now, except for one nit...
> ---
> hw/ppc/spapr.c | 2 ++
> hw/ppc/spapr_caps.c | 17 +++++++++++++++++
> include/hw/ppc/spapr.h | 5 ++++-
> 3 files changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index b6a571b6f1..acf62a2b9f 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -2077,6 +2077,7 @@ static const VMStateDescription vmstate_spapr = {
> &vmstate_spapr_irq_map,
> &vmstate_spapr_cap_nested_kvm_hv,
> &vmstate_spapr_dtb,
> + &vmstate_spapr_cap_large_decr,
> NULL
> }
> };
> @@ -4288,6 +4289,7 @@ static void spapr_machine_class_init(ObjectClass *oc,
> void *data)
> smc->default_caps.caps[SPAPR_CAP_IBS] = SPAPR_CAP_BROKEN;
> smc->default_caps.caps[SPAPR_CAP_HPT_MAXPAGESIZE] = 16; /* 64kiB */
> smc->default_caps.caps[SPAPR_CAP_NESTED_KVM_HV] = SPAPR_CAP_OFF;
> + smc->default_caps.caps[SPAPR_CAP_LARGE_DECREMENTER] = 0;
... since this is now a boolean, it should use SPAPR_CAP_OFF /
SPAPR_CAP_ON instead of bare 0 and 1.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
