On Fri, 22 Feb 2019 at 15:53, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Fri, Feb 22, 2019 at 03:47:36PM +0000, Peter Maydell wrote: > > Compile failure on clang: > > > > /home/petmay01/linaro/qemu-for-merges/hw/virtio/virtio-balloon.c:40:3: > > error: redefinition of typedef 'PartiallyBalloonedPage' is a C11 > > feature [-Werror,-Wtypedef-redefinition] > > } PartiallyBalloonedPage; > > ^ > > /home/petmay01/linaro/qemu-for-merges/include/hw/virtio/virtio-balloon.h:33:39: > > note: previous definition is here > > typedef struct PartiallyBalloonedPage PartiallyBalloonedPage; > > ^ > > 1 error generated. > > /home/petmay01/linaro/qemu-for-merges/rules.mak:69: recipe for target > > 'hw/virtio/virtio-balloon.o' failed
> Fixed up and re-pushed. > David, pls note above and don't add duplicate typedefs in the future. > There's always include/qemu/typedefs.h if you don't know where > to put a typedef. It's an easy mistake to make, and it's only clang that complains -- I did it myself the other week :-) thanks -- PMM
