On 2/22/19 9:16 AM, Daniel P. Berrangé wrote: > On Fri, Feb 22, 2019 at 04:06:32PM +0100, Max Reitz wrote: >> On 20.02.19 15:58, Daniel P. Berrangé wrote: >>> If we abort the iotest early the server.log file might contain useful >>> information for diagnosing the problem. Ensure its contents are >>> displayed in this case. >>> >>> Reviewed-by: Eric Blake <ebl...@redhat.com> >>> Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
>>> @@ -120,6 +122,7 @@ $QEMU_IO -f $IMGFMT -r -U -c 'r -P 0x22 1m 1m' >>> "$TEST_IMG" | _filter_qemu_io >>> echo >>> echo "== final server log ==" >>> cat "$TEST_DIR/server.log" >>> +rm -f $TEST_DIR/server.log >> >> I'm not sure how well the iotests currently cope with spaced dir names >> anyway, but it looks weird to not use quotes here right after a line >> that does. > > Yes, that is a mistake since we tried quoting throughout the file Can fix that while staging through my NBD queue. I'll probably send a PR on Monday. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
