On Wed, Feb 20, 2019 at 07:24:00AM +0100, Thomas Huth wrote: > On 19/02/2019 21.19, Michael S. Tsirkin wrote: > > On Tue, Feb 19, 2019 at 05:07:39PM +0100, Thomas Huth wrote: > >> Some machines have an AHCI adapter, but no PCI. To be able to > >> compile hw/ide/ahci.c without CONFIG_PCI, we still need the two > >> functions msi_enabled() and msi_notify() for linking. > >> This is required for the upcoming Kconfig-like build system, if > >> a user wants to compile a QEMU binary with just one machine that > >> has AHCI, but no PCI, like the ARM "cubieboard" for example. > >> > >> Signed-off-by: Thomas Huth <th...@redhat.com> > > > > Reviewed-by: Michael S. Tsirkin <m...@redhat.com> > > Thanks! > > > Do you want me to merge this or do you prefer to > > merge it with kconfig patches? > > If you plan a pci pull request soon, feel free to take it. Otherwise, I > can also add it to my Kconfig-for-arm patch series where I need it. > > Thomas
Feel free to include but please talk to Paolo about his ideas for abstracting it out. Thanks! -- MST
