On 2/19/19 11:39 PM, Like Xu wrote: > On 2019/2/20 11:09, Eric Blake wrote: >> On 2/20/19 2:55 AM, Like Xu wrote: >>> Signed-off-by: Like Xu <like...@linux.intel.com> >> >> This feels like two independent patches - the .gitignore change is >> different from typo fixes. >> >> Actually, for .gitignore, you could just as easily do: >> >> echo '*.patch' >> .git/info/exclude >> >> and fix it so you never commit patch files locally, while still leaving >> them visible through 'git status' to other users. I actually like >> knowing when I have stale patch files lying around, so that I can 'rm' >> them before creating my next patch batch and using 'git send-email >> *.patch' - but of course, I could just as easily add '!*.patch' to my >> .git/info/exclude to override the project default if we decide to go >> with your patch. > > Adding '*.patch' to .gitignore is consistent with LKML tree.
Fair enough - but then make it a separate patch, and include that justification in your commit message. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
