On 03/25/2011 05:11 PM, Michael Roth wrote:
Why are these options required?
The qmp_proxy_new() constructor expects a path to a socket it can
connect() to. Not sure about telnet, but the other options are
required for this. Well...server=on at least, wait=off needs to be set
as well because that's the only way to have the socket chardev set the
listening socket to non-block, since qmp_proxy_new() calls connect()
on it before we return to the main I/O loop.
Although, we probably shouldn't just silently switch out explicitly
set options; an error would probably be more appropriate here.
You ought to make qmp_proxy_new() return a CharDriverState such that you
can do:
qemu -device virtio-serial,chardev=foo -chardev guest-agent,id=foo
Regards,
Anthony Liguori
Regards,
Anthony Liguori
