13.02.2019 11:19, Stefan Hajnoczi wrote: > On Thu, Feb 07, 2019 at 01:24:28PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> Here is a new simple helper for a very often patter >> around qemu_iovec_init_external, when we need simple qiov with only >> one iov, initialized from external buffer. >> >> v3: > > Hi Vladimir, > "make check" is failing: > > TEST check-qtest-x86_64: tests/ide-test > qemu-system-x86_64: /home/stefanha/qemu/include/qemu/iov.h:195: > qemu_iovec_get_buf: Assertion `qiov->niov == -1 && qiov->iov == > &qiov->local_iov' failed. > > Please take a look and send v4. > > Stefan >
Oops, sorry for this, it obviously should be qiov->nalloc == -1 in assertion. I'll resend and rename s/qemu_iovec_get_buf/qemu_iovec_embedded_buf/ to make it more obvious. -- Best regards, Vladimir
