On 23.01.19 11:33, Stefan Hajnoczi wrote: > The previous patch includes the LUKS payload overhead into the qemu-img > measure calculation for qcow2. Update qemu-iotests 178 to exercise this > new code path. > > Reviewed-by: Max Reitz <mre...@redhat.com> > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > --- > tests/qemu-iotests/178 | 8 ++++++++ > tests/qemu-iotests/178.out.qcow2 | 24 ++++++++++++++++++++++++ > 2 files changed, 32 insertions(+) > > diff --git a/tests/qemu-iotests/178 b/tests/qemu-iotests/178 > index 3f4b4a4564..23eb017ea1 100755 > --- a/tests/qemu-iotests/178 > +++ b/tests/qemu-iotests/178 > @@ -142,6 +142,14 @@ for ofmt in human json; do > # The backing file doesn't need to exist :) > $QEMU_IMG measure --output=$ofmt -o backing_file=x \ > -f "$fmt" -O "$IMGFMT" "$TEST_IMG" > + > + echo > + echo "== $fmt input image and LUKS encryption ==" > + echo > + $QEMU_IMG measure --output=$ofmt \ > + --object secret,id=sec0,data=base \ > + -o encrypt.format=luks,encrypt.key-secret=sec0 > \ > + -f "$fmt" -O "$IMGFMT" "$TEST_IMG"
With the change in patch 1, it would be possible to set encrypt.iter-time=10, for example (default for the LUKS tests). For me, that decreases the test's runtime from 24 to 15 seconds. Pretty please? :-) Max > fi > > echo
signature.asc
Description: OpenPGP digital signature