On 14/02/19 17:40, Peter Maydell wrote: >> --- >> hw/i386/pc.c | 8 +------ >> include/standard-headers/asm-x86/bootparam.h | 34 >> ++++++++++++++++++++++++++++ >> scripts/update-linux-headers.sh | 6 +++++ >> 3 files changed, 41 insertions(+), 7 deletions(-) >> create mode 100644 include/standard-headers/asm-x86/bootparam.h > Hi -- I just noticed this commit while I was looking through > git logs for a different reason. For future changes to > the standard-headers/, can we keep the "change the update > script" patches separate from the "and now update the headers > from upstream kernel commit X with the new script" parts, > please? Otherwise it's very hard to be sure that the header > changes are correct and that we still have an in-sync > set of header files that aren't a patchwork of files from > different versions. (For instance, this commit claims it is > "from v4.20-rc5", but the rest of the header files are already > at 4.21-rc1/5.0-rc1.)
Yes, will do. (FWIW, the file hasn't changed between v4.20-rc5 and v5.0-rc1). Paolo
