Hi Yuval,
On 2/13/19 8:53 AM, Yuval Shaia wrote:
Hi,
Please review the following patch-set which consist of cosmetics fixes to
device's user interface (traces, error_report and monitor) and some bug
fixes.
Thanks Markus, Eric, Marcel and David for reviewing v0.
Appreciate your review to this v2.
clang compilation fails.
Please use this configuration:
configure --target-list="x86_64-softmmu" --cc=clang --enable-pvrdma
It will fail with:
In file included from
/home/mapfelba/git/upstream/qemu/hw/rdma/rdma_backend.c:32:
In file included from /home/mapfelba/git/upstream/qemu/hw/rdma/rdma_rm.h:21:
/home/mapfelba/git/upstream/qemu/hw/rdma/rdma_rm_defs.h:108:3: error:
redefinition of typedef 'RdmaDeviceResources' is a C11 feature
[-Werror,-Wtypedef-redefinition]
} RdmaDeviceResources;
^
/home/mapfelba/git/upstream/qemu/hw/rdma/rdma_backend_defs.h:24:36:
note: previous definition is here
typedef struct RdmaDeviceResources RdmaDeviceResources;
^
1 error generated.
make[1]: *** [/home/mapfelba/git/upstream/qemu/rules.mak:69:
hw/rdma/rdma_backend.o] Error 1
make[1]: *** Waiting for unfinished jobs....
In file included from /home/mapfelba/git/upstream/qemu/hw/rdma/rdma_rm.c:21:
In file included from
/home/mapfelba/git/upstream/qemu/hw/rdma/rdma_backend.h:22:
/home/mapfelba/git/upstream/qemu/hw/rdma/rdma_rm_defs.h:108:3: error:
redefinition of typedef 'RdmaDeviceResources' is a C11 feature
[-Werror,-Wtypedef-redefinition]
} RdmaDeviceResources;
^
/home/mapfelba/git/upstream/qemu/hw/rdma/rdma_backend_defs.h:24:36:
note: previous definition is here
typedef struct RdmaDeviceResources RdmaDeviceResources;
^
1 error generated.
make[1]: *** [/home/mapfelba/git/upstream/qemu/rules.mak:69:
hw/rdma/rdma_rm.o] Error 1
In file included from
/home/mapfelba/git/upstream/qemu/hw/rdma/vmw/pvrdma_qp_ops.c:19:
In file included from
/home/mapfelba/git/upstream/qemu/hw/rdma/vmw/../rdma_rm.h:21:
/home/mapfelba/git/upstream/qemu/hw/rdma/vmw/../rdma_rm_defs.h:108:3:
error: redefinition of typedef 'RdmaDeviceResources' is a C11 feature
[-Werror,-Wtypedef-redefinition]
} RdmaDeviceResources;
^
/home/mapfelba/git/upstream/qemu/hw/rdma/vmw/../rdma_backend_defs.h:24:36:
note: previous definition is here
typedef struct RdmaDeviceResources RdmaDeviceResources;
^
1 error generated.
make[1]: *** [/home/mapfelba/git/upstream/qemu/rules.mak:69:
hw/rdma/vmw/pvrdma_qp_ops.o] Error 1
In file included from
/home/mapfelba/git/upstream/qemu/hw/rdma/vmw/pvrdma_cmd.c:23:
In file included from
/home/mapfelba/git/upstream/qemu/hw/rdma/vmw/../rdma_backend.h:22:
/home/mapfelba/git/upstream/qemu/hw/rdma/vmw/../rdma_rm_defs.h:108:3:
error: redefinition of typedef 'RdmaDeviceResources' is a C11 feature
[-Werror,-Wtypedef-redefinition]
} RdmaDeviceResources;
^
/home/mapfelba/git/upstream/qemu/hw/rdma/vmw/../rdma_backend_defs.h:24:36:
note: previous definition is here
typedef struct RdmaDeviceResources RdmaDeviceResources;
^
Thanks,
Marcel
