On 12/3/18 11:52 AM, Max Reitz wrote: > This new error option allows users of blkdebug to inject errors only on > certain kinds of I/O operations. Users usually want to make a very > specific operation fail, not just any; but right now they simply hope > that the event that triggers the error injection is followed up with > that very operation. That may not be true, however, because the block > layer is changing (including blkdebug, which may increase the number of > types of I/O operations on which to inject errors). > > The new option's default has been chosen to keep backwards > compatibility. > > Note that similar to the internal representation, we could choose to > expose this option as a list of I/O types. But there is no practical > use for this, because as described above, users usually know exactly > which kind of operation they want to make fail, so there is no need to > specify multiple I/O types at once. In addition, exposing this option > as a list would require non-trivial changes to qemu_opts_absorb_qdict(). > > Signed-off-by: Max Reitz <mre...@redhat.com> > --- > If you want @iotype be a list, I have patches.
Might be interesting to see, whether or not we take them. > --- > qapi/block-core.json | 26 +++++++++++++++++++++++ > block/blkdebug.c | 50 ++++++++++++++++++++++++++++++++++++-------- > 2 files changed, 67 insertions(+), 9 deletions(-) > Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
