On Tue, Feb 12, 2019 at 03:29:17PM -0600, Michael Roth wrote: > Commit 7be41675f7c set -std=gnu99 for C code via QEMU_CFLAGS. Currently > we generate a "custom" QEMU_CXXFLAGS for VSS DLL C++ build by > filtering out some options from QEMU_CFLAGS and adding some others. > Since we don't filter out -std=gnu99 currently this breaks builds when > VSS support is enabled. > > We could keep the existing approach, filter out -std=gnu99 from > QEMU_CFLAGS, and add -std=gnu++98, like configure currently does for > QEMU_CXXFLAGS, but as it turns out our resulting QEMU_CXXFLAGS would > be exactly what configure already generates, just with these filtered > out: > > -fstack-protector-all -fstack-protector-strong > > and these added: > > -Wno-unknown-pragmas -Wno-delete-non-virtual-dtor > > So fix the issue by re-using configure-generated QEMU_CXXFLAGS and > just handling these specific changes. > > Signed-off-by: Michael Roth <mdr...@linux.vnet.ibm.com> > --- > qga/vss-win32/Makefile.objs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
