> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 14.01.2019 um 12:10 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 09.01.2019 um 13:13 hat Pavel Dovgalyuk geschrieben: > > > > Replay is capable of recording normal BH events, but sometimes > > > > there are single use callbacks scheduled with aio_bh_schedule_oneshot > > > > function. This patch enables recording and replaying such callbacks. > > > > Block layer uses these events for calling the completion function. > > > > Replaying these calls makes the execution deterministic. > > > > > > > > Signed-off-by: Pavel Dovgalyuk <pavel.dovga...@ispras.ru> > > > > > > This still doesn't come even close to catching all BHs that need to be > > > caught. While you managed to show a few BHs that actually don't need to > > > be considered for recording when I asked for this in v7, most BHs in the > > > block layer can in some way lead to device callbacks and must therefore > > > be recorded. > > > > Let's have a brief review. I can change all the places, but how > > should I make a test case to be sure, that all of them are working ok? > > The list is changing all the time. This is why I am so concerned about > special-casing a few callers instead of having a generic solution. I > don't know how we could make sure that we call the right function > everywhere.
I changed all oneshot invocations in the block layer in the new version. Can you review it and other block-related patches? Pavel Dovgalyuk
