On 2/12/19 5:04 AM, Cornelia Huck wrote: > On Mon, 11 Feb 2019 20:16:55 -0500 > Collin Walling <wall...@linux.ibm.com> wrote: > >> The extended PTFF features (qsie, qtoue, stoe, stoue) are dependent >> on the multiple-epoch facility (mepoch). Let's print a warning if these >> features are enabled without mepoch. >> >> While we're at it, let's move the FEAT_GROUP_INIT for mepochptff down >> the s390_feature_groups list so it can be properly indexed with its >> generated S390FeatGroup enum. >> >> Signed-off-by: Collin Walling <wall...@linux.ibm.com> >> --- >> target/s390x/cpu_features.c | 2 +- >> target/s390x/cpu_models.c | 4 ++++ >> 2 files changed, 5 insertions(+), 1 deletion(-) > > Not a comment for this patch (looks fine to me), but more general: > Could you please add a cover letter if you send more than one patch? > It's easy to miss that there are three patches and not two :) >
Noted. Thanks for the advice! -- Respectfully, - Collin Walling