Re: [Qemu-devel] [PATCH v1 8/9] hw/pvrdma: Delete pvrdma_exit function

[Marcel Apfelbaum]

On 2/10/19 12:45 PM, Yuval Shaia wrote:

This hook is not called and was implemented by mistake.

Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com>
---
  hw/rdma/vmw/pvrdma_main.c | 6 ------
  1 file changed, 6 deletions(-)

diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c
index 90dc9b191b..8b379c6435 100644
--- a/hw/rdma/vmw/pvrdma_main.c
+++ b/hw/rdma/vmw/pvrdma_main.c
@@ -701,18 +701,12 @@ out:
      }
  }

-static void pvrdma_exit(PCIDevice *pdev)

-{
-    pvrdma_fini(pdev);
-}
-
  static void pvrdma_class_init(ObjectClass *klass, void *data)
  {
      DeviceClass *dc = DEVICE_CLASS(klass);
      PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);

k->realize = pvrdma_realize;

-    k->exit = pvrdma_exit;
      k->vendor_id = PCI_VENDOR_ID_VMWARE;
      k->device_id = PCI_DEVICE_ID_VMWARE_PVRDMA;
      k->revision = 0x00;

Reviewed-by: Marcel Apfelbaum <marcel.apfelb...@gmail.com>

Thanks,
Marcel