On 2/5/19 11:06 AM, Peter Maydell wrote: > On Mon, 14 Jan 2019 at 01:11, Richard Henderson > <richard.hender...@linaro.org> wrote: >> >> When MTE is fully enabled, i.e. access to tags are enabled and >> tag checks affect the PE, then arrange to perform the check >> while stripping the TBI. >> >> The check is not yet implemented, just the plumbing to that point. >> >> Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > > >> @@ -0,0 +1,32 @@ >> +/* >> + * ARM v8.5-MemTag Operations >> + * >> + * Copyright (c) 2019 Linaro, Ltd. >> + * >> + * This library is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU Lesser General Public >> + * License as published by the Free Software Foundation; either >> + * version 2 of the License, or (at your option) any later version. > > Do you mean LGPL version 2.1 here, or GPL version 2?
Exactly the same as all of the other Linaro contributed files -- a confused mix. ;-) >> +uint64_t HELPER(mte_check)(CPUARMState *env, uint64_t ptr) >> +{ >> + /* Only unchecked implemented so far. */ >> + return sextract64(ptr, 0, 55); > > Are you sure this is right? Not exactly right, no. I thought I had a fixme here, but that was the other one you point out later. Will fix. r~