Patchew URL: https://patchew.org/QEMU/20190208224020.GA4670@nyan/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] hw/arm/bcm2835_peripheral: add bcm283x sp804-alike timer Type: series Message-id: 20190208224020.GA4670@nyan === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190130210350.16757-1-luke.r.n...@gmail.com -> patchew/20190130210350.16757-1-luke.r.n...@gmail.com * [new tag] patchew/20190208224020.GA4670@nyan -> patchew/20190208224020.GA4670@nyan Switched to a new branch 'test' a1e2330d4d hw/arm/bcm2835_peripheral: add bcm283x sp804-alike timer === OUTPUT BEGIN === Argument "m" isn't numeric in numeric eq (==) at ./scripts/checkpatch.pl line 2771. Argument "m" isn't numeric in numeric eq (==) at ./scripts/checkpatch.pl line 2771. Use of uninitialized value $1 in concatenation (.) or string at ./scripts/checkpatch.pl line 2772. WARNING: line over 80 characters #25: FILE: hw/arm/bcm2835_peripherals.c:122: + object_initialize(&s->bcm283xsp804, sizeof(s->bcm283xsp804), TYPE_BCM283xSP804); WARNING: line over 80 characters #26: FILE: hw/arm/bcm2835_peripherals.c:123: + object_property_add_child(obj, "bcm283xsp804", OBJECT(&s->bcm283xsp804), NULL); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 ERROR: do not use C99 // comments #90: FILE: hw/timer/bcm283x_timer.c:27: + int prev_div; // Not implemented ERROR: do not use C99 // comments #91: FILE: hw/timer/bcm283x_timer.c:28: + int free_run_cnt; // Not implemented WARNING: line over 80 characters #116: FILE: hw/timer/bcm283x_timer.c:53: + /* The register is write-only, but returns reverse "ARMT" string bytes */ ERROR: braces {} are necessary for all arms of this statement #121: FILE: hw/timer/bcm283x_timer.c:58: + if ((s->control & TIMER_CTRL_IE) == 0) [...] ERROR: switch and case should be at the same indent #146: FILE: hw/timer/bcm283x_timer.c:83: + switch (offset >> 2) { + case 0: /* Load register */ [...] + case 1: /* Value register */ [...] + case 2: /* Control register */ [...] + case 3: /* IRQ clear/ACK register */ [...] + case 6: /* Reload register */ [...] + default: ERROR: trailing statements should be on next line #164: FILE: hw/timer/bcm283x_timer.c:101: + case 1: freq >>= 4; break; /* 16 */ ERROR: trailing statements should be on next line #165: FILE: hw/timer/bcm283x_timer.c:102: + case 2: freq >>= 8; break; /* 256 */ ERROR: unnecessary cast may hide bugs, use g_new0 instead #215: FILE: hw/timer/bcm283x_timer.c:152: + s = (bcm283x_timer_state *) g_malloc0(sizeof(bcm283x_timer_state)); WARNING: line over 80 characters #228: FILE: hw/timer/bcm283x_timer.c:165: +/* XXX: BCM's datasheet does not seem to provide these values and they may differ */ WARNING: line over 80 characters #262: FILE: hw/timer/bcm283x_timer.c:199: + "%s: integration test registers unimplemented\n", __func__); WARNING: line over 80 characters #271: FILE: hw/timer/bcm283x_timer.c:208: +static void bcm283xsp803_write(void *opaque, hwaddr offset, uint64_t value, unsigned size) WARNING: line over 80 characters #306: FILE: hw/timer/bcm283x_timer.c:243: + memory_region_init_io(&s->iomem, obj, &bcm283xsp804_ops, s, "bcm283xsp804", 0x1000); WARNING: line over 80 characters #395: FILE: include/hw/timer/bcm283x_timer.h:23: +#define BCM283xSP804(obj) OBJECT_CHECK(BCM283xSP804State, (obj), TYPE_BCM283xSP804) total: 7 errors, 9 warnings, 366 lines checked Commit a1e2330d4de2 (hw/arm/bcm2835_peripheral: add bcm283x sp804-alike timer) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190208224020.GA4670@nyan/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
