Marc-André Lureau <marcandre.lur...@redhat.com> writes: > Hi > > On Wed, Feb 6, 2019 at 7:17 PM Markus Armbruster <arm...@redhat.com> wrote: >> >> We neglect to call .visit_module() for the special module we use for >> built-ins. Harmless, but clean it up anyway. The >> tests/qapi-schema/*.out now show the built-in module as 'module None'. >> >> Subclasses of QAPISchemaModularCVisitor need to ._add_module() this >> special module to enable code generation for built-ins. When this >> hasn't been done, QAPISchemaModularCVisitor.visit_module() does >> nothing for the special module. That looks like built-ins could >> accidentally be generated into the wrong module when a subclass >> neglects to call ._add_module(). Can't happen, because built-ins are >> all visited before any other module. But that's non-obvious. Switch >> off code generation explicitly. >> >> Split QAPISchemaModularCVisitor._add_module() into ._add_user_module() >> and ._add_system_module(), for clarity. > > That's in next patch.
You caught me fiddling with the patch split after having written the commit messages. Will fix. >> Rename QAPISchemaModularCVisitor._begin_module() to >> ._begin_user_module(). >> >> New QAPISchemaModularCVisitor._is_builtin_module(), for clarity. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> > > Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> Thanks!
