On 2/6/19 1:55 PM, Max Reitz wrote: > There already is an optional discriminator test, although it also noted > the discriminator name itself as optional. This already gives us one > error test case, to which this patch adds various others. > > Furthermore, a passing test case is added to qapi-schema-test. > > Signed-off-by: Max Reitz <mre...@redhat.com> > --- Reviewed-by: Eric Blake <ebl...@redhat.com>
This could also be squashed with patch 1 to avoid a window of 'make check' breakage during a bisect; but as that makes the overall changes bigger to review, leaving them separate is not too terrible. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
