On Tue, Feb 5, 2019 at 7:22 AM Luc Michel <luc.mic...@greensocs.com> wrote:
>
>
>
> On 2/5/19 1:58 PM, Thomas Huth wrote:
> > The device can not be instantiated by the user and QEMU currently
> > aborts when you try to use it:
> >
> > $ x86_64-softmmu/qemu-system-x86_64 -device cpu-cluster
> > qemu-system-x86_64: hw/cpu/cluster.c:73: cpu_cluster_realize:
> > Assertion `cbdata.cpu_count > 0' failed.
> > Aborted (core dumped)
> >
> > Since this is an internal device only, mark it with user_creatable = false.
> >
> > Signed-off-by: Thomas Huth <th...@redhat.com>
> Reviewed-by: Luc Michel <luc.mic...@greensocs.com>
Reviewed-by: Alistair Francis <alistair.fran...@wdc.com>
Alistair
>
> > ---
> > hw/cpu/cluster.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/hw/cpu/cluster.c b/hw/cpu/cluster.c
> > index 25f9070..6f5f037 100644
> > --- a/hw/cpu/cluster.c
> > +++ b/hw/cpu/cluster.c
> > @@ -79,6 +79,9 @@ static void cpu_cluster_class_init(ObjectClass *klass,
> > void *data)
> >
> > dc->props = cpu_cluster_properties;
> > dc->realize = cpu_cluster_realize;
> > +
> > + /* This is not directly for users, CPU children must be attached by
> > code */
> > + dc->user_creatable = false;
> > }
> >
> > static const TypeInfo cpu_cluster_type_info = {
> >
>
