On Mon, Feb 04, 2019 at 03:29:21PM +0000, Daniel P. Berrangé wrote: > On Mon, Feb 04, 2019 at 10:19:42AM -0500, Michael S. Tsirkin wrote: > > Hmm I do think we want to build the contrib tools, > > otherwise they bitrot too quickly, witness follow-up > > patches that fix the compilation. > > > > And I think we need tests that actually use them. > > > > However I agree adding them to tools and installing > > is probably rushing things, e.g. there's no > > manpage even. > > Yes, if we build, but do not install, the binary that would be ok > > > Regards, > Daniel
OK I reverted this for now. > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
