On 02/02/19 00:03, Philippe Mathieu-Daudé wrote: > On 2/1/19 11:35 PM, Laszlo Ersek wrote: >> On 01/31/19 19:55, Laszlo Ersek wrote:
>>> (1) How *exactly* does it fail for you? > > In my mailbox the mail appears with Message-ID: > cf693646-58c8-8810-58a1-a6e503636...@redhat.com in response to > https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06393.html but > I can't see the mail on the public archives :/ Ouch. I've now searched my mailbox for the Message-ID above, and there's no match. Too bad your email got lost. >> (f) So, the solution is to prefix the "./build.sh" recipe with a "+" >> sign, to mark it as "recursive": >> >>> diff --git a/tests/uefi-test-tools/Makefile b/tests/uefi-test-tools/Makefile >>> index 61d263861e..449b81d8ba 100644 >>> --- a/tests/uefi-test-tools/Makefile >>> +++ b/tests/uefi-test-tools/Makefile >>> @@ -87,7 +87,7 @@ Build/%.fat: Build/%.efi >>> .NOTPARALLEL: >>> >>> Build/bios-tables-test.%.efi: build-edk2-tools >>> - ./build.sh $(edk2_dir) BiosTablesTest $* $@ >>> + +./build.sh $(edk2_dir) BiosTablesTest $* $@ > > Yes :) This fixed it! > >>> >>> build-edk2-tools: >>> $(MAKE) -C $(edk2_dir)/BaseTools >> >> This fixes the issue for me on Fedora 29, without breaking the behavior >> on RHEL7. > > Excellent! I triggered Travis builds (Ubuntu/Debian). > >> >> I'll submit v3 later. Thank you for catching this error. > > Now that we are happy, maybe Michael can do this change when applying, > but I guess you'd prefer first to write a line about this '+' in the > commit message or the Makefile. That's right, I'd like to extend the comment that we already have in the Makefile about .NOTPARALLEL, with a note on the "+" indicator. > > With the +: > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > Tested-by: Philippe Mathieu-Daudé <phi...@redhat.com> Awesome, thank you! :) > > Thanks a lot for figuring this out alone and fixing it! It definitely helped that you mentioned your use of Fedora 29 earlier :) Also, we're very lucky that GNU Make's documentation is so nice. Thanks, Laszlo
