On 2/2/19 12:00 AM, Michael S. Tsirkin wrote: > Comment near strncpy explains kernel_cmdline does > not need to be 0-terminated. > > Accordingly mark it as QEMU_NONSTRING. > > Without this, gcc warns: > 'strncpy' specified bound 256 equals destination size > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > hw/sh4/r2d.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c > index 5b399e7161..dcdb3728cb 100644 > --- a/hw/sh4/r2d.c > +++ b/hw/sh4/r2d.c > @@ -220,7 +220,7 @@ static struct QEMU_PACKED > > char pad[232]; > > - char kernel_cmdline[256]; > + char kernel_cmdline[256] QEMU_NONSTRING; > } boot_params; > > static void r2d_init(MachineState *machine) >
