On Fri, 1 Feb 2019 at 16:41, Alex Bennée <alex.ben...@linaro.org> wrote: > > > Peter Maydell <peter.mayd...@linaro.org> writes:
> > +# General information about the project. > > +project = u'QEMU' > > +copyright = u'2019, The QEMU Project Developers' > > Hmm I bet we forget to update this date. Does it have to be the date the > text was last touched or could we just go from the last commit in the tree? Yeah, this isn't ideal, but the same applies to the string in QEMU_COPYRIGHT in qemu-common.h (as you can tell from the fact that still says 2018!). If we can fix that to be generated from something else we can fish it out when we do the docs build too. > > +author = u'The QEMU Project Developers' > > + > > +# The version info for the project you're documenting, acts as replacement > > for > > +# |version| and |release|, also used in various other places throughout the > > +# built documents. > > +# > > +# The short X.Y version. > > +version = u'4.0' > > +# The full version, including alpha/beta/rc tags. > > +release = u'4.0' > > Surely these need to come from the build system the same way the > build-id does? Yes, see later patch in the series. The idea with the patchset structure here was that this patch is basically just the autogenerated stuff (sphinx-quickstart asks a few simple questions like project name and author which fills these in), and then the following patches customize that. That seemed to me like it would be easier to review than if I just squashed everything into a single patch. thanks -- PMM
