Patchew URL: https://patchew.org/QEMU/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree Type: series Message-id: 20190122092909.5341-1-kbast...@mail.uni-paderborn.de === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190122092909.5341-1-kbast...@mail.uni-paderborn.de -> patchew/20190122092909.5341-1-kbast...@mail.uni-paderborn.de Switched to a new branch 'test' 707ba25e6a target/riscv: Remaining rvc insn reuse 32 bit translators e8e3fdd801 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 1271fb32d1 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 e57717196e target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 9a48b3870f target/riscv: Convert @cs_2 insns to share translation functions ae50456b4a target/riscv: Remove decode_RV32_64G() 689db535fa target/riscv: Remove gen_system() ba19bbe72c target/riscv: Rename trans_arith to gen_arith 4821480397 target/riscv: Remove manual decoding of RV32/64M insn bc78e8b198 target/riscv: Remove shift and slt insn manual decoding b24202ed1b target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists c4655ea1af target/riscv: Move gen_arith_imm() decoding into trans_* functions f4b51a8879 target/riscv: Remove manual decoding from gen_store() 271753698f target/riscv: Remove manual decoding from gen_load() ce1206dbc3 target/riscv: Remove manual decoding from gen_branch() 35a81db796 target/riscv: Remove gen_jalr() 8d3033de1a target/riscv: Convert quadrant 2 of RVXC insns to decodetree 7f04cc7343 target/riscv: Convert quadrant 1 of RVXC insns to decodetree 6a1f9394fa target/riscv: Convert quadrant 0 of RVXC insns to decodetree 84311c64b5 target/riscv: Convert RV priv insns to decodetree 801dbbdb4c target/riscv: Convert RV64D insns to decodetree 566965419e target/riscv: Convert RV32D insns to decodetree e2646f4afe target/riscv: Convert RV64F insns to decodetree 188a6e6678 target/riscv: Convert RV32F insns to decodetree c39a5a597a target/riscv: Convert RV64A insns to decodetree 74169b8e38 target/riscv: Convert RV32A insns to decodetree f0db8bcb9c target/riscv: Convert RVXM insns to decodetree 2db8b9a367 target/riscv: Convert RVXI csr insns to decodetree abf36dbe82 target/riscv: Convert RVXI fence insns to decodetree 437709e78b target/riscv: Convert RVXI arithmetic insns to decodetree 201f108c71 target/riscv: Convert RV64I load/store insns to decodetree 7c6f47530c target/riscv: Convert RV32I load/store insns to decodetree 9e5332de20 target/riscv: Convert RVXI branch insns to decodetree dc69d0a085 target/riscv: Activate decodetree and implemnt LUI & AUIPC b4e49789dd target/riscv: Move CPURISCVState pointer to DisasContext === OUTPUT BEGIN === 1/35 Checking commit b4e49789dd4a (target/riscv: Move CPURISCVState pointer to DisasContext) 2/35 Checking commit dc69d0a0852a (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1687: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 2/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/35 Checking commit 9e5332de20d5 (target/riscv: Convert RVXI branch insns to decodetree) 4/35 Checking commit 7c6f47530cd9 (target/riscv: Convert RV32I load/store insns to decodetree) 5/35 Checking commit 201f108c71a8 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 5/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/35 Checking commit 437709e78b8c (target/riscv: Convert RVXI arithmetic insns to decodetree) 7/35 Checking commit abf36dbe8296 (target/riscv: Convert RVXI fence insns to decodetree) 8/35 Checking commit 2db8b9a36725 (target/riscv: Convert RVXI csr insns to decodetree) 9/35 Checking commit f0db8bcb9cb8 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 145 lines checked Patch 9/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/35 Checking commit 74169b8e3825 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 188 lines checked Patch 10/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/35 Checking commit c39a5a597a18 (target/riscv: Convert RV64A insns to decodetree) 12/35 Checking commit 188a6e6678b6 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 397 lines checked Patch 12/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/35 Checking commit e2646f4afea5 (target/riscv: Convert RV64F insns to decodetree) 14/35 Checking commit 566965419e20 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 353 lines checked Patch 14/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/35 Checking commit 801dbbdb4c1d (target/riscv: Convert RV64D insns to decodetree) 16/35 Checking commit 84311c64b54d (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 16/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/35 Checking commit 6a1f9394fa9b (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #246: FILE: target/riscv/translate.c:983: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 227 lines checked Patch 17/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/35 Checking commit 7f04cc73436d (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 19/35 Checking commit 8d3033de1a18 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 20/35 Checking commit 35a81db7962a (target/riscv: Remove gen_jalr()) 21/35 Checking commit ce1206dbc3c3 (target/riscv: Remove manual decoding from gen_branch()) 22/35 Checking commit 271753698faf (target/riscv: Remove manual decoding from gen_load()) 23/35 Checking commit f4b51a887927 (target/riscv: Remove manual decoding from gen_store()) 24/35 Checking commit c4655ea1af1a (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 25/35 Checking commit b24202ed1b5e (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 26/35 Checking commit bc78e8b19846 (target/riscv: Remove shift and slt insn manual decoding) 27/35 Checking commit 4821480397dc (target/riscv: Remove manual decoding of RV32/64M insn) 28/35 Checking commit ba19bbe72c20 (target/riscv: Rename trans_arith to gen_arith) 29/35 Checking commit 689db535faaf (target/riscv: Remove gen_system()) 30/35 Checking commit ae50456b4a24 (target/riscv: Remove decode_RV32_64G()) 31/35 Checking commit 9a48b3870f4c (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:497: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 31/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 32/35 Checking commit e57717196e63 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 33/35 Checking commit 1271fb32d170 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 287 lines checked Patch 33/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 34/35 Checking commit e8e3fdd80100 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 35/35 Checking commit 707ba25e6ad9 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
