Patchew URL: https://patchew.org/QEMU/20190131130016.17337-1-kra...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190131130016.17337-1-kra...@redhat.com Subject: [Qemu-devel] [PATCH v3] scripts: use git archive in archive-source Type: series === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20190123092538.8004-1-kbast...@mail.uni-paderborn.de -> patchew/20190123092538.8004-1-kbast...@mail.uni-paderborn.de Switched to a new branch 'test' cfe9664 scripts: use git archive in archive-source === OUTPUT BEGIN === ERROR: code indent should never use tabs #57: FILE: scripts/archive-source.sh:42: +^Istatus="$(git submodule status "$sm")"$ ERROR: code indent should never use tabs #58: FILE: scripts/archive-source.sh:43: +^Ismhash="${status# }"$ ERROR: code indent should never use tabs #59: FILE: scripts/archive-source.sh:44: +^Ismhash="${smhash#+}"$ ERROR: code indent should never use tabs #60: FILE: scripts/archive-source.sh:45: +^Ismhash="${smhash#-}"$ ERROR: code indent should never use tabs #61: FILE: scripts/archive-source.sh:46: +^Ismhash="${smhash%% *}"$ ERROR: code indent should never use tabs #62: FILE: scripts/archive-source.sh:47: +^Ismdir="$sm"$ ERROR: code indent should never use tabs #63: FILE: scripts/archive-source.sh:48: +^Icase "$status" in$ ERROR: code indent should never use tabs #64: FILE: scripts/archive-source.sh:49: +^I -*)$ ERROR: code indent should never use tabs #65: FILE: scripts/archive-source.sh:50: +^I^Ismdir="$sub_tdir/$sm"$ ERROR: code indent should never use tabs #66: FILE: scripts/archive-source.sh:51: +^I^Ismurl="$(git config -f .gitmodules submodule.${sm}.url)"$ ERROR: code indent should never use tabs #67: FILE: scripts/archive-source.sh:52: +^I^Iecho "NOTICE: using temporary clone for submodule $sm"$ ERROR: code indent should never use tabs #68: FILE: scripts/archive-source.sh:53: +^I^Igit clone "$smurl" "$smdir"$ ERROR: code indent should never use tabs #69: FILE: scripts/archive-source.sh:54: +^I^Itest $? -ne 0 && error "failed to clone submodule $sm"$ ERROR: code indent should never use tabs #70: FILE: scripts/archive-source.sh:55: +^I^I;;$ ERROR: code indent should never use tabs #71: FILE: scripts/archive-source.sh:56: +^I +*)$ ERROR: code indent should never use tabs #72: FILE: scripts/archive-source.sh:57: +^I^Iecho "WARNING: submodule $sm is out of sync"$ ERROR: code indent should never use tabs #73: FILE: scripts/archive-source.sh:58: +^I^I;;$ ERROR: code indent should never use tabs #74: FILE: scripts/archive-source.sh:59: +^Iesac$ WARNING: line over 80 characters #75: FILE: scripts/archive-source.sh:60: + (cd $smdir; git archive --format tar --prefix "$sm/" $smhash) > "$sub_file" ERROR: code indent should never use tabs #75: FILE: scripts/archive-source.sh:60: +^I(cd $smdir; git archive --format tar --prefix "$sm/" $smhash) > "$sub_file"$ ERROR: code indent should never use tabs #76: FILE: scripts/archive-source.sh:61: +^Itest $? -ne 0 && error "failed to archive submodule $sm ($smhash)"$ ERROR: code indent should never use tabs #77: FILE: scripts/archive-source.sh:62: +^Itar --concatenate --file "$tar_file" "$sub_file"$ ERROR: code indent should never use tabs #78: FILE: scripts/archive-source.sh:63: +^Itest $? -ne 0 && error "failed append submodule $sm to $tar_file"$ total: 22 errors, 1 warnings, 58 lines checked Commit cfe96645bc47 (scripts: use git archive in archive-source) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190131130016.17337-1-kra...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
