On Thu, Jan 31, 2019 at 12:15:17PM -0500, Michael S. Tsirkin wrote: > On Thu, Jan 31, 2019 at 04:19:09PM +0100, Stefano Garzarella wrote: > > This series adds the support of DISCARD and WRITE ZEROES commands > > and extends the virtio-blk-test to test WRITE_ZEROES command when > > the feature is enabled. > > > > v2: > > - added patch 1 to use virtio_blk_handle_rw_error() with discard operation > > - added patch 2 to make those new features machine-type dependent (thanks > > David) > > - fixed patch 3 (previously patch 1/2) adding more checks, > > block_acct_start() > > for WRITE_ZEROES requests, and configurable parameters to > > initialize the limits (max_sectors, wzeroes_may_unmap). > > (thanks Stefan) > > I moved in a new function the code to handle a single > > segment, > > in order to simplify the support of multiple segments in the > > future. > > - added patch 4 to change the assert on data_size following the discussion > > with > > Thomas, Changpeng, Michael, and Stefan (thanks all) > > - fixed patch 5 (previously patch 2/2) using local dwz_hdr variable instead > > of > > dynamic allocation (thanks Thomas) > > > > This series requires the new virtio headers from linux v5.0-rc1 > > already imported by Paolo: > > > > Based-on: <20190104082731.24967-1-pbonz...@redhat.com> > > > > Thanks, > > Stefano > > series: > > Reviewed-by: Michael S. Tsirkin <m...@redhat.com> > > > merge through block tree I guess? >
I guess too. Thanks for the review! Stefano
