On 1/31/19 7:08 AM, Yuval Shaia wrote: > Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> > --- > hmp-commands-info.hx | 14 ++++++++++++++ > monitor.c | 6 ++++++ > 2 files changed, 20 insertions(+)
Commit message should state WHY this is being added as an HMP-only command, and does not have a QMP counterpart. It may be okay if the interface is only designed to be useful to developers, but having that justification in the git log is important. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
