On Mon, 28 Jan 2019 at 14:56, Daniel P. Berrangé <berra...@redhat.com> wrote: > > On Mon, Jan 28, 2019 at 01:46:57PM +0000, Peter Maydell wrote: > > qemu-icon.bmp seems also to still be listed in the LINKS > > in configure which defines what we symlink from the source > > tree to the build tree (and again, the png files are not). > > Wierd, I don't understand why we need any of that LINKS stuff in > configure. Not having the png files listed doesn't cause any > obvious problem that I can see. For that matter nor does having > the (now deleted) qemu-icon.bmp seem to cause a failure, as we > silent ignore source tree files that don't exist.
The LINKS stuff is so that you can run binaries from out of the build directory and have them find things like the BIOS blobs. In this case presumably a QEMU run from the build dir wouldn't find its icon (unless somebody had done a 'make install' on the system in the past). Though something doesn't seem quite right here, because the sdl2.c code is looking for icon files in a hicolor/ subdirectory that doesn't exist in the source tree. thanks -- PMM
