On 1/25/19 4:24 PM, Thomas Huth wrote: > On 2019-01-25 16:14, kumar sourav wrote: >> Sets the category of i8042 device as DEVICE_CATEGORY_INPUT >> Devices should be assigned to one of DEVICE_CATEGORY_XXXX. >> >> Signed-off-by: kumar sourav <sourav.jb1...@gmail.com> >> --- >> hw/input/pckbd.c | 1 +
It seems we have other potential cases: $ git grep -L 'set_bit(DEVICE_CATEGORY_INPUT' hw/input/*c hw/input/adb.c hw/input/hid.c hw/input/lm832x.c hw/input/milkymist-softusb.c hw/input/pckbd.c hw/input/pl050.c hw/input/ps2.c hw/input/pxa2xx_keypad.c hw/input/stellaris_input.c hw/input/tsc2005.c hw/input/tsc210x.c hw/input/virtio-input-hid.c hw/input/virtio-input-host.c >> 1 file changed, 1 insertion(+) >> >> diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c >> index 3e66713b47..72e7d5f6cc 100644 >> --- a/hw/input/pckbd.c >> +++ b/hw/input/pckbd.c >> @@ -574,6 +574,7 @@ static void i8042_class_initfn(ObjectClass *klass, void >> *data) >> >> dc->realize = i8042_realizefn; >> dc->vmsd = &vmstate_kbd_isa; >> + set_bit(DEVICE_CATEGORY_INPUT, dc->categories); >> } >> >> static const TypeInfo i8042_info = { >> > > Reviewed-by: Thomas Huth <th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>