Hi,
> On Jan 24, 2019, at 8:07 PM, Gerd Hoffmann <kra...@redhat.com> wrote:
>
>> diff --git a/include/ui/egl-helpers.h b/include/ui/egl-helpers.h
>> index 3fc656a..63ffc2d 100644
>> --- a/include/ui/egl-helpers.h
>> +++ b/include/ui/egl-helpers.h
>> @@ -28,6 +28,8 @@ void egl_fb_read(void *dst, egl_fb *src);
>> void egl_texture_blit(QemuGLShader *gls, egl_fb *dst, egl_fb *src, bool
>> flip);
>> void egl_texture_blend(QemuGLShader *gls, egl_fb *dst, egl_fb *src, bool
>> flip,
>> int x, int y);
>> +void egl_texture_blend2(QemuGLShader *gls, egl_fb *dst, egl_fb *src, bool
>> flip,
>> + int x, int y, int w, int h);
>
> Why do you add egl_texture_blend2()?
> How about adding scale_{x,y} parameters to egl_texture_blend() instead?
It is valid to augment parameter list of egl_texture_blend(), however, there
are
two other callers: namely, spicy-display and egl-headless, neither of which
seems to scale any underlying viewports. In that case, default scales (1.0,
1.0)
shall be provided.
>
>> + vc->gfx.scale_x * vc->gfx.cursor_fb.width,
>> + vc->gfx.scale_x * vc->gfx.cursor_fb.height);
> ^ this should be y I guess ?
Sorry for this typo.
>
> cheers,
> Gerd
>
Best regards,
