Isaku Yamahata <yamah...@valinux.co.jp> wrote:
> PIIX3State::pci_irq_levels are redundant which is already tracked by
> PCIBus layer. So eliminate them.
1st of all: Hurray to remove the entable between PIIX3State & i440fx.
> Cc: Michael S. Tsirkin <m...@redhat.com>
> Signed-off-by: Isaku Yamahata <yamah...@valinux.co.jp>
> ---
> hw/piix_pci.c | 31 +++++++++++++++++++++----------
> 1 files changed, 21 insertions(+), 10 deletions(-)
>
> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> index 358da58..a1d1f55 100644
> --- a/hw/piix_pci.c
> +++ b/hw/piix_pci.c
> @@ -39,7 +39,7 @@ typedef PCIHostState I440FXState;
>
> typedef struct PIIX3State {
> PCIDevice dev;
> - int pci_irq_levels[4];
> + int32_t dummy_for_save_load_compat[4];
Rest of devices normally call it:
int32_t pci_irq_levels_vmstate[4];
Putting it as the last member of the struct helps (sometimes) with cache
performance issues.
Rest look nice. Thanks.
