On 1/21/19 8:22 PM, Eric Blake wrote: > On 1/21/19 12:10 PM, Philippe Mathieu-Daudé wrote: >> Commit 2974e916df8 introduced the VirtioNetRscChain structure which >> refer to a VirtIONet, declared later, thus required VirtIONet typedef >> to be declarated forward. > > s/be declarated forward/use a forward declaration/
Thanks Eric. Thomas, do you mind fixing this if you take this patch? >> However, when compiling with Clang in -std=gnu99 mode, this triggers >> the following warning/error: >> >> CC hw/net/virtio-net.o >> In file included from qemu/hw/net/virtio-net.c:22: >> include/hw/virtio/virtio-net.h:189:3: error: redefinition of typedef >> 'VirtIONet' is a C11 feature [-Werror,-Wtypedef-redefinition] >> } VirtIONet; >> ^ >> include/hw/virtio/virtio-net.h:110:26: note: previous definition is here >> typedef struct VirtIONet VirtIONet; >> ^ >> 1 error generated. >> make: *** [rules.mak:69: hw/net/virtio-net.o] Error 1 >> >> Fix it by removing the duplicate typedef definition. >> >> Reported-by: Peter Maydell <peter.mayd...@linaro.org> >> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> >> --- >> include/hw/virtio/virtio-net.h | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) > > Reviewed-by: Eric Blake <ebl...@redhat.com> >
signature.asc
Description: OpenPGP digital signature
