On 2019-01-21 14:15, Yoshinori Sato wrote: > This part only supported RXv1 instructions. > Instruction manual. > https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01us0032ej0120_rxsm.pdf > > Signed-off-by: Yoshinori Sato <ys...@users.sourceforge.jp> > --- [...] > diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c > new file mode 100644 > index 0000000000..c9c87dc308 > --- /dev/null > +++ b/target/rx/op_helper.c > @@ -0,0 +1,548 @@ > +/* > + * RX helper functions > + * > + * Copyright (c) 2018 Yoshinori Sato > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2 of the License, or (at your option) any later version.
Hi, just a short meta comment for all the new files in your patch series: It's either GNU *Library* General Public License, version 2 or GNU Lesser General Public License, version *2.1* I'd suggest to go with "Lesser" and "2.1". Apart from that, it might be a good idea to CC: some people who are familiar with TCG if you want to make sure to get some review (see the MAINTAINERS file for example). Thanks, Thomas PS: Seems like we've got this "Lesser" vs. "Library" wrong in a couple of other source files in QEMU ... I'll try to come up with a patch to fix this in the files that we've already got in the repo.
