Peter Maydell <peter.mayd...@linaro.org> writes:
> On Fri, 18 Jan 2019 at 18:16, Emilio G. Cota <c...@braap.org> wrote: >> >> On Fri, Jan 18, 2019 at 17:00:17 +0000, Alex Bennée wrote: >> > Philippe Mathieu-Daudé <phi...@redhat.com> writes: >> > > Can you modify the Makefile.include to use: >> > > "fp-test ... 2>int-to-float.err || {cat int-to-float.err && exit 1;}" >> > >> > Well it's in the test-softfloat macro but sure... >> >> Actually, can we do &> instead of 2> ? > > "&>" is a bashism. The POSIX equivalent is >file.err 2>&1 > > thanks > -- PMM I've gone for this: # $1 = tests, $2 = description test-softfloat = $(call quiet-command, \ - cd $(BUILD_DIR)/tests/fp && ./fp-test -s $(FP_TL) $1 > $2.out 2> $2.err, \ + cd $(BUILD_DIR)/tests/fp && \ + ./fp-test -s $(FP_TL) $1 > $2.out 2>&1 || \ + (cat $2.out && exit 1;), \ "FLOAT TEST", $2) As for the tests it seems quite a lot are broken on s390x for a reason I don't quite follow yet: i32_to_f128 i64_to_f128 ui64_to_f128 extF80_to_i32 extF80_to_i32_r_minMag extF80_eq and more which I haven't confirmed yet. I'm tempted to ifndef the tests for s390 for now while we sort out what's going on. Should I re-send with that? -- Alex Bennée