On Fri, Jan 18, 2019 at 06:03:46PM +0100, Paolo Bonzini wrote: > On 18/01/19 17:36, Michael S. Tsirkin wrote: > >> config PCI_GENERIC > >> bool > >> + select PCIE > >> > > > > why is this? > > > > PCI_GENERIC is hw/pci-host/gpex.c, the "QEMU Generic PCI Express Bridge > Emulation".
Oh. Not really descriptive. I guess we should rename it to PCI_EXPRESS_GENERIC_BRIDGE or something? > >> config PCI_XILINX > >> bool > >> + select PCIE > >> > >> config PCI_DESIGNWARE > >> bool > >> + select PCIE > > > > > > sure about the above? > > The comments at the top of the two files say they are PCIe. > > Paolo So I guess the part that I find confusing is which module it is. Module should be a prefix. So if module is PCI then everything should be PCI_ and PCIE should be PCI_EXPRESS. If PCIE is the module then all these guys should be renamed. -- MST
