On Tue, 8 Jan 2019 at 22:32, Richard Henderson <richard.hender...@linaro.org> wrote: > > Use TBID in aa64_va_parameters depending on the data parameter. > This automatically updates all existing users of the function. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > ---
> ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, > ARMMMUIdx mmu_idx, bool data) > { > - return aa64_va_parameters_both(env, va, mmu_idx); > + ARMVAParameters ret = aa64_va_parameters_both(env, va, mmu_idx); > + > + /* Present TBI as a composite with TBID. */ > + ret.tbi &= (data || !ret.tbid); > + return ret; It took me a good couple of minutes to to work out if this expression actually did what the docs say TBID is supposed to do... Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM