On 1/16/19 1:19 PM, Paul Durrant wrote: >> -----Original Message----- >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> Sent: 16 January 2019 12:14 >> To: peter.mayd...@linaro.org >> Cc: qemu-devel@nongnu.org; Alex Bennée <alex.ben...@linaro.org>; Stefano >> Stabellini <sstabell...@kernel.org>; Anthony Perard >> <anthony.per...@citrix.com>; Paul Durrant <paul.durr...@citrix.com>; Kevin >> Wolf <kw...@redhat.com>; Max Reitz <mre...@redhat.com>; open list:X86 >> <xen-de...@lists.xenproject.org>; open list:Block layer core <qemu- >> bl...@nongnu.org> >> Subject: [PATCH] hw/block/xen: use proper format string for printing >> sectors >> >> The %lu format string is different depending on the host architecture >> which causes builds like the debian-armhf-cross build to fail. Use the >> correct PRi64 format string. >> >> Signed-off-by: Alex Bennée <alex.ben...@linaro.org> > > This does the same thing as "xen: Fix format string" from Philippe, but this > variant is better...
OK. Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > > Reviewed-by: Paul Durrant <paul.durr...@citrix.com> > >> --- >> hw/block/xen-block.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c >> index be28b63442..a636487b3e 100644 >> --- a/hw/block/xen-block.c >> +++ b/hw/block/xen-block.c >> @@ -215,7 +215,7 @@ static void xen_block_realize(XenDevice *xendev, Error >> **errp) >> >> xen_device_backend_printf(xendev, "sector-size", "%u", >> conf->logical_block_size); >> - xen_device_backend_printf(xendev, "sectors", "%lu", >> + xen_device_backend_printf(xendev, "sectors", "%"PRIi64, >> blk_getlength(conf->blk) / >> conf->logical_block_size); >> >> -- >> 2.17.1 >
