On 1/14/19 3:36 PM, Thomas Huth wrote: > On 2019-01-14 15:31, Philippe Mathieu-Daudé wrote: >> On 1/14/19 2:46 PM, Thomas Huth wrote: >>> The header "scsi-lowlevel.h" of libiscsi 1.9.0 contains some bad >>> "inline" prototype definitions which GCC refuses to compile in its >>> gnu99 mode: >>> >>> In file included from block/iscsi.c:52:0: >>> /usr/include/iscsi/scsi-lowlevel.h:810:13: error: inline function >>> ‘scsi_set_uint16’ declared but never defined [-Werror] >>> inline void scsi_set_uint16(unsigned char *c, uint16_t val); >>> ^ >>> /usr/include/iscsi/scsi-lowlevel.h:809:13: error: inline function >>> ‘scsi_set_uint32’ declared but never defined [-Werror] >>> inline void scsi_set_uint32(unsigned char *c, uint32_t val); >>> ^ >>> >>> This has been fixed by upstream libiscsi in version 1.10.0 (see >>> https://github.com/sahlberg/libiscsi/commit/7692027d6c11 ), but >>> since we still want to support 1.9.0 for CentOS 7 / RHEL7, we >>> have to work-around the issue by compiling with "-fgnu89-inline" >>> in this case instead. >>> >>> Suggested-by: Daniel P. Berrangé <berra...@redhat.com> >>> Signed-off-by: Thomas Huth <th...@redhat.com> >>> --- >>> configure | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/configure b/configure >>> index 2b9ba7d..aa80c17 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -4562,6 +4562,11 @@ if test "$libiscsi" != "no" ; then >>> libiscsi="yes" >>> libiscsi_cflags=$($pkg_config --cflags libiscsi) >>> libiscsi_libs=$($pkg_config --libs libiscsi) >>> + if $pkg_config --exact-version==1.9.0 libiscsi; then >> >> The first offending commit is d327ab09c which got included in 1.8.0, so >> using "exact" is not correct. > We require at least version 1.9.0, so the only version which can have > this problem when compiling QEMU is 1.9.0.
Oh you are right, then: Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
