On Fri, Jan 11, 2019 at 06:16:45PM +0000, Peter Maydell wrote: > On Fri, 11 Jan 2019 at 18:13, Anthony PERARD <anthony.per...@citrix.com> > wrote: > > > > On Fri, Jan 11, 2019 at 06:09:41PM +0000, Anthony PERARD wrote: > > > Patch "xen: add event channel interface for XenDevice-s" makes use of > > > the type xenevtchn_port_or_error_t, but this isn't avaiable before Xen > > > 4.7. Also the function xen_device_bind_event_channel assign the return > > > value of xenevtchn_bind_interdomain to channel->local_port but check the > > > result for error with xendev->local_port. > > > > > > Fix by: > > > - removing local_port from struct XenDevice as it isn't use anywere. > > > - adding a compatibility typedef for xenevtchn_port_or_error_t for Xen > > > 4.6 and earlier. > > > > > > As extra, replace the type of XenEventChannel->local_port by > > > evtchn_port_t. > > > > > > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> > > > > Notes: > > This patch fix "xen: add event channel interface for XenDevice-s" that > > isn't commited yet, of the patch series "Xen PV backend 'qdevification'". > > Thanks for the fix. I assume you're going to squash it into the > appropriate patch in that pullrequest ?
Yes, it's a good idea to squash it. I'll resubmit the pullreq shortly. -- Anthony PERARD
