Patchew URL: https://patchew.org/QEMU/20181217231639.24250-1-pbonz...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181217231639.24250-1-pbonz...@redhat.com Subject: [Qemu-devel] [PATCH] crypto: finish removing TABs === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 99bac12 crypto: finish removing TABs === OUTPUT BEGIN === ERROR: line over 90 characters #26: FILE: crypto/aes.c:1064: + 0x1B000000, 0x36000000, /* for 128-bit blocks, Rijndael never uses more than 10 rcon values */ ERROR: braces {} are necessary for all arms of this statement #47: FILE: crypto/aes.c:1077: + if (!userKey || !key) [...] ERROR: braces {} are necessary for all arms of this statement #49: FILE: crypto/aes.c:1079: + if (bits != 128 && bits != 192 && bits != 256) [...] ERROR: spaces required around that '==' (ctx:VxV) #61: FILE: crypto/aes.c:1084: + if (bits==128) ^ ERROR: braces {} are necessary for all arms of this statement #61: FILE: crypto/aes.c:1084: + if (bits==128) [...] + else if (bits==192) [...] + else [...] ERROR: spaces required around that '==' (ctx:VxV) #63: FILE: crypto/aes.c:1086: + else if (bits==192) ^ ERROR: braces {} are necessary for all arms of this statement #63: FILE: crypto/aes.c:1086: + else if (bits==192) [...] + else [...] ERROR: space prohibited before that close parenthesis ')' #76: FILE: crypto/aes.c:1091: + rk[0] = GETU32(userKey ); ERROR: space prohibited after that open square bracket '[' #118: FILE: crypto/aes.c:1117: + temp = rk[ 5]; ERROR: space prohibited after that open square bracket '[' #119: FILE: crypto/aes.c:1118: + rk[ 6] = rk[ 0] ^ ERROR: space prohibited after that open square bracket '[' #143: FILE: crypto/aes.c:1124: + rk[ 7] = rk[ 1] ^ rk[ 6]; ERROR: space prohibited after that open square bracket '[' #144: FILE: crypto/aes.c:1125: + rk[ 8] = rk[ 2] ^ rk[ 7]; ERROR: space prohibited after that open square bracket '[' #145: FILE: crypto/aes.c:1126: + rk[ 9] = rk[ 3] ^ rk[ 8]; ERROR: space prohibited after that open square bracket '[' #149: FILE: crypto/aes.c:1130: + rk[10] = rk[ 4] ^ rk[ 9]; ERROR: space prohibited after that open square bracket '[' #150: FILE: crypto/aes.c:1131: + rk[11] = rk[ 5] ^ rk[10]; ERROR: space prohibited after that open square bracket '[' #158: FILE: crypto/aes.c:1139: + temp = rk[ 7]; ERROR: space prohibited after that open square bracket '[' #159: FILE: crypto/aes.c:1140: + rk[ 8] = rk[ 0] ^ ERROR: space prohibited after that open square bracket '[' #174: FILE: crypto/aes.c:1146: + rk[ 9] = rk[ 1] ^ rk[ 8]; ERROR: space prohibited after that open square bracket '[' #175: FILE: crypto/aes.c:1147: + rk[10] = rk[ 2] ^ rk[ 9]; ERROR: space prohibited after that open square bracket '[' #176: FILE: crypto/aes.c:1148: + rk[11] = rk[ 3] ^ rk[10]; ERROR: space prohibited after that open square bracket '[' #181: FILE: crypto/aes.c:1153: + rk[12] = rk[ 4] ^ ERROR: space prohibited after that open square bracket '[' #189: FILE: crypto/aes.c:1158: + rk[13] = rk[ 5] ^ rk[12]; ERROR: space prohibited after that open square bracket '[' #190: FILE: crypto/aes.c:1159: + rk[14] = rk[ 6] ^ rk[13]; ERROR: space prohibited after that open square bracket '[' #191: FILE: crypto/aes.c:1160: + rk[15] = rk[ 7] ^ rk[14]; ERROR: braces {} are necessary for all arms of this statement #221: FILE: crypto/aes.c:1180: + if (status < 0) [...] ERROR: spaces required around that '*' (ctx:VxV) #239: FILE: crypto/aes.c:1186: + for (i = 0, j = 4*(key->rounds); i < j; i += 4, j -= 4) { ^ ERROR: space prohibited before that close square bracket ']' #240: FILE: crypto/aes.c:1187: + temp = rk[i ]; rk[i ] = rk[j ]; rk[j ] = temp; ERROR: line over 90 characters #245: FILE: crypto/aes.c:1192: + /* apply the inverse MixColumn transform to all round keys but the first and the last: */ ERROR: space prohibited before that close parenthesis ')' #311: FILE: crypto/aes.c:1240: + s0 = GETU32(in ) ^ rk[0]; ERROR: spaces required around that '=' (ctx:VxV) #574: FILE: crypto/aes.c:1617: + for(n=0; n < AES_BLOCK_SIZE; ++n) ^ ERROR: space required before the open parenthesis '(' #574: FILE: crypto/aes.c:1617: + for(n=0; n < AES_BLOCK_SIZE; ++n) ERROR: braces {} are necessary for all arms of this statement #574: FILE: crypto/aes.c:1617: + for(n=0; n < AES_BLOCK_SIZE; ++n) [...] ERROR: spaces required around that '=' (ctx:VxV) #583: FILE: crypto/aes.c:1626: + for(n=0; n < len; ++n) ^ ERROR: space required before the open parenthesis '(' #583: FILE: crypto/aes.c:1626: + for(n=0; n < len; ++n) ERROR: braces {} are necessary for all arms of this statement #583: FILE: crypto/aes.c:1626: + for(n=0; n < len; ++n) [...] ERROR: spaces required around that '=' (ctx:VxV) #585: FILE: crypto/aes.c:1628: + for(n=len; n < AES_BLOCK_SIZE; ++n) ^ ERROR: space required before the open parenthesis '(' #585: FILE: crypto/aes.c:1628: + for(n=len; n < AES_BLOCK_SIZE; ++n) ERROR: braces {} are necessary for all arms of this statement #585: FILE: crypto/aes.c:1628: + for(n=len; n < AES_BLOCK_SIZE; ++n) [...] ERROR: spaces required around that '=' (ctx:VxV) #595: FILE: crypto/aes.c:1638: + for(n=0; n < AES_BLOCK_SIZE; ++n) ^ ERROR: space required before the open parenthesis '(' #595: FILE: crypto/aes.c:1638: + for(n=0; n < AES_BLOCK_SIZE; ++n) ERROR: braces {} are necessary for all arms of this statement #595: FILE: crypto/aes.c:1638: + for(n=0; n < AES_BLOCK_SIZE; ++n) [...] ERROR: spaces required around that '=' (ctx:VxV) #605: FILE: crypto/aes.c:1648: + for(n=0; n < len; ++n) ^ ERROR: space required before the open parenthesis '(' #605: FILE: crypto/aes.c:1648: + for(n=0; n < len; ++n) ERROR: braces {} are necessary for all arms of this statement #605: FILE: crypto/aes.c:1648: + for(n=0; n < len; ++n) [...] ERROR: code indent should never use tabs #629: FILE: crypto/desrfb.c:43: + 0x800000L,^I0x400000L,^I0x200000L,^I0x100000L,$ ERROR: code indent should never use tabs #630: FILE: crypto/desrfb.c:44: + 0x80000L,^I0x40000L,^I0x20000L,^I0x10000L,$ ERROR: code indent should never use tabs #631: FILE: crypto/desrfb.c:45: + 0x8000L,^I0x4000L,^I0x2000L,^I0x1000L,$ ERROR: code indent should never use tabs #632: FILE: crypto/desrfb.c:46: + 0x800L, ^I0x400L, ^I0x200L, ^I0x100L,$ ERROR: code indent should never use tabs #633: FILE: crypto/desrfb.c:47: + 0x80L,^I^I0x40L,^I^I0x20L,^I^I0x10L,$ ERROR: code indent should never use tabs #634: FILE: crypto/desrfb.c:48: + 0x8L,^I^I0x4L,^I^I0x2L,^I^I0x1L^I};$ ERROR: code indent should never use tabs #643: FILE: crypto/desrfb.c:53: + 56, 48, 40, 32, 24, 16, 8,^I 0, 57, 49, 41, 33, 25, 17,$ ERROR: code indent should never use tabs #644: FILE: crypto/desrfb.c:54: + 9, 1, 58, 50, 42, 34, 26,^I18, 10, 2, 59, 51, 43, 35,$ ERROR: code indent should never use tabs #645: FILE: crypto/desrfb.c:55: + 62, 54, 46, 38, 30, 22, 14,^I 6, 61, 53, 45, 37, 29, 21,$ ERROR: code indent should never use tabs #646: FILE: crypto/desrfb.c:56: + 13, 5, 60, 52, 44, 36, 28,^I20, 12, 4, 27, 19, 11, 3 };$ ERROR: space required after that ',' (ctx:VxV) #650: FILE: crypto/desrfb.c:59: + 1,2,4,6,8,10,12,14,15,17,19,21,23,25,27,28 }; ^ ERROR: space required after that ',' (ctx:VxV) #650: FILE: crypto/desrfb.c:59: + 1,2,4,6,8,10,12,14,15,17,19,21,23,25,27,28 }; ^ ERROR: space required after that ',' (ctx:VxV) #650: FILE: crypto/desrfb.c:59: + 1,2,4,6,8,10,12,14,15,17,19,21,23,25,27,28 }; ^ ERROR: space required after that ',' (ctx:VxV) #650: FILE: crypto/desrfb.c:59: + 1,2,4,6,8,10,12,14,15,17,19,21,23,25,27,28 }; ^ ERROR: space required after that ',' (ctx:VxV) #650: FILE: crypto/desrfb.c:59: + 1,2,4,6,8,10,12,14,15,17,19,21,23,25,27,28 }; ^ ERROR: space required after that ',' (ctx:VxV) #650: FILE: crypto/desrfb.c:59: + 1,2,4,6,8,10,12,14,15,17,19,21,23,25,27,28 }; ^ ERROR: space required after that ',' (ctx:VxV) #650: FILE: crypto/desrfb.c:59: + 1,2,4,6,8,10,12,14,15,17,19,21,23,25,27,28 }; ^ ERROR: space required after that ',' (ctx:VxV) #650: FILE: crypto/desrfb.c:59: + 1,2,4,6,8,10,12,14,15,17,19,21,23,25,27,28 }; ^ ERROR: space required after that ',' (ctx:VxV) #650: FILE: crypto/desrfb.c:59: + 1,2,4,6,8,10,12,14,15,17,19,21,23,25,27,28 }; ^ ERROR: space required after that ',' (ctx:VxV) #650: FILE: crypto/desrfb.c:59: + 1,2,4,6,8,10,12,14,15,17,19,21,23,25,27,28 }; ^ ERROR: space required after that ',' (ctx:VxV) #650: FILE: crypto/desrfb.c:59: + 1,2,4,6,8,10,12,14,15,17,19,21,23,25,27,28 }; ^ ERROR: space required after that ',' (ctx:VxV) #650: FILE: crypto/desrfb.c:59: + 1,2,4,6,8,10,12,14,15,17,19,21,23,25,27,28 }; ^ ERROR: space required after that ',' (ctx:VxV) #650: FILE: crypto/desrfb.c:59: + 1,2,4,6,8,10,12,14,15,17,19,21,23,25,27,28 }; ^ ERROR: space required after that ',' (ctx:VxV) #650: FILE: crypto/desrfb.c:59: + 1,2,4,6,8,10,12,14,15,17,19,21,23,25,27,28 }; ^ ERROR: space required after that ',' (ctx:VxV) #650: FILE: crypto/desrfb.c:59: + 1,2,4,6,8,10,12,14,15,17,19,21,23,25,27,28 }; ^ ERROR: space prohibited after that open parenthesis '(' #700: FILE: crypto/desrfb.c:74: + for ( j = 0; j < 56; j++ ) { ERROR: space prohibited before that close parenthesis ')' #700: FILE: crypto/desrfb.c:74: + for ( j = 0; j < 56; j++ ) { ERROR: space prohibited after that open parenthesis '(' #705: FILE: crypto/desrfb.c:79: + for( i = 0; i < 16; i++ ) { ERROR: space prohibited before that close parenthesis ')' #705: FILE: crypto/desrfb.c:79: + for( i = 0; i < 16; i++ ) { ERROR: space required before the open parenthesis '(' #705: FILE: crypto/desrfb.c:79: + for( i = 0; i < 16; i++ ) { ERROR: space prohibited after that open parenthesis '(' #706: FILE: crypto/desrfb.c:80: + if( edf == DE1 ) m = (15 - i) << 1; ERROR: space prohibited before that close parenthesis ')' #706: FILE: crypto/desrfb.c:80: + if( edf == DE1 ) m = (15 - i) << 1; ERROR: space required before the open parenthesis '(' #706: FILE: crypto/desrfb.c:80: + if( edf == DE1 ) m = (15 - i) << 1; ERROR: trailing statements should be on next line #706: FILE: crypto/desrfb.c:80: + if( edf == DE1 ) m = (15 - i) << 1; ERROR: braces {} are necessary for all arms of this statement #706: FILE: crypto/desrfb.c:80: + if( edf == DE1 ) m = (15 - i) << 1; [...] + else m = i << 1; [...] ERROR: trailing statements should be on next line #707: FILE: crypto/desrfb.c:81: + else m = i << 1; ERROR: space prohibited after that open parenthesis '(' #710: FILE: crypto/desrfb.c:84: + for( j = 0; j < 28; j++ ) { ERROR: space prohibited before that close parenthesis ')' #710: FILE: crypto/desrfb.c:84: + for( j = 0; j < 28; j++ ) { ERROR: space required before the open parenthesis '(' #710: FILE: crypto/desrfb.c:84: + for( j = 0; j < 28; j++ ) { ERROR: space prohibited after that open parenthesis '(' #712: FILE: crypto/desrfb.c:86: + if( l < 28 ) pcr[j] = pc1m[l]; ERROR: space prohibited before that close parenthesis ')' #712: FILE: crypto/desrfb.c:86: + if( l < 28 ) pcr[j] = pc1m[l]; ERROR: space required before the open parenthesis '(' #712: FILE: crypto/desrfb.c:86: + if( l < 28 ) pcr[j] = pc1m[l]; ERROR: trailing statements should be on next line #712: FILE: crypto/desrfb.c:86: + if( l < 28 ) pcr[j] = pc1m[l]; ERROR: braces {} are necessary for all arms of this statement #712: FILE: crypto/desrfb.c:86: + if( l < 28 ) pcr[j] = pc1m[l]; [...] + else pcr[j] = pc1m[l - 28]; [...] ERROR: trailing statements should be on next line #713: FILE: crypto/desrfb.c:87: + else pcr[j] = pc1m[l - 28]; ERROR: space prohibited after that open parenthesis '(' #715: FILE: crypto/desrfb.c:89: + for( j = 28; j < 56; j++ ) { ERROR: space prohibited before that close parenthesis ')' #715: FILE: crypto/desrfb.c:89: + for( j = 28; j < 56; j++ ) { ERROR: space required before the open parenthesis '(' #715: FILE: crypto/desrfb.c:89: + for( j = 28; j < 56; j++ ) { ERROR: space prohibited after that open parenthesis '(' #717: FILE: crypto/desrfb.c:91: + if( l < 56 ) pcr[j] = pc1m[l]; ERROR: space prohibited before that close parenthesis ')' #717: FILE: crypto/desrfb.c:91: + if( l < 56 ) pcr[j] = pc1m[l]; ERROR: space required before the open parenthesis '(' #717: FILE: crypto/desrfb.c:91: + if( l < 56 ) pcr[j] = pc1m[l]; ERROR: trailing statements should be on next line #717: FILE: crypto/desrfb.c:91: + if( l < 56 ) pcr[j] = pc1m[l]; ERROR: braces {} are necessary for all arms of this statement #717: FILE: crypto/desrfb.c:91: + if( l < 56 ) pcr[j] = pc1m[l]; [...] + else pcr[j] = pc1m[l - 28]; [...] ERROR: trailing statements should be on next line #718: FILE: crypto/desrfb.c:92: + else pcr[j] = pc1m[l - 28]; ERROR: space prohibited after that open parenthesis '(' #720: FILE: crypto/desrfb.c:94: + for( j = 0; j < 24; j++ ) { ERROR: space prohibited before that close parenthesis ')' #720: FILE: crypto/desrfb.c:94: + for( j = 0; j < 24; j++ ) { ERROR: space required before the open parenthesis '(' #720: FILE: crypto/desrfb.c:94: + for( j = 0; j < 24; j++ ) { ERROR: space prohibited after that open parenthesis '(' #721: FILE: crypto/desrfb.c:95: + if( pcr[pc2[j]] ) kn[m] |= bigbyte[j]; ERROR: space prohibited before that close parenthesis ')' #721: FILE: crypto/desrfb.c:95: + if( pcr[pc2[j]] ) kn[m] |= bigbyte[j]; ERROR: space required before the open parenthesis '(' #721: FILE: crypto/desrfb.c:95: + if( pcr[pc2[j]] ) kn[m] |= bigbyte[j]; ERROR: trailing statements should be on next line #721: FILE: crypto/desrfb.c:95: + if( pcr[pc2[j]] ) kn[m] |= bigbyte[j]; ERROR: braces {} are necessary for all arms of this statement #721: FILE: crypto/desrfb.c:95: + if( pcr[pc2[j]] ) kn[m] |= bigbyte[j]; [...] ERROR: spaces required around that '+' (ctx:VxV) #722: FILE: crypto/desrfb.c:96: + if( pcr[pc2[j+24]] ) kn[n] |= bigbyte[j]; ^ ERROR: space prohibited after that open parenthesis '(' #722: FILE: crypto/desrfb.c:96: + if( pcr[pc2[j+24]] ) kn[n] |= bigbyte[j]; ERROR: space prohibited before that close parenthesis ')' #722: FILE: crypto/desrfb.c:96: + if( pcr[pc2[j+24]] ) kn[n] |= bigbyte[j]; ERROR: space required before the open parenthesis '(' #722: FILE: crypto/desrfb.c:96: + if( pcr[pc2[j+24]] ) kn[n] |= bigbyte[j]; ERROR: trailing statements should be on next line #722: FILE: crypto/desrfb.c:96: + if( pcr[pc2[j+24]] ) kn[n] |= bigbyte[j]; ERROR: braces {} are necessary for all arms of this statement #722: FILE: crypto/desrfb.c:96: + if( pcr[pc2[j+24]] ) kn[n] |= bigbyte[j]; [...] ERROR: space prohibited after that open parenthesis '(' #754: FILE: crypto/desrfb.c:110: + for( i = 0; i < 16; i++, raw1++ ) { ERROR: space prohibited before that close parenthesis ')' #754: FILE: crypto/desrfb.c:110: + for( i = 0; i < 16; i++, raw1++ ) { ERROR: space required before the open parenthesis '(' #754: FILE: crypto/desrfb.c:110: + for( i = 0; i < 16; i++, raw1++ ) { ERROR: code indent should never use tabs #756: FILE: crypto/desrfb.c:112: + *cook^I = (*raw0 & 0x00fc0000L) << 6;$ ERROR: code indent should never use tabs #757: FILE: crypto/desrfb.c:113: + *cook^I|= (*raw0 & 0x00000fc0L) << 10;$ ERROR: code indent should never use tabs #758: FILE: crypto/desrfb.c:114: + *cook^I|= (*raw1 & 0x00fc0000L) >> 10;$ ERROR: code indent should never use tabs #760: FILE: crypto/desrfb.c:116: + *cook^I = (*raw0 & 0x0003f000L) << 12;$ ERROR: code indent should never use tabs #761: FILE: crypto/desrfb.c:117: + *cook^I|= (*raw0 & 0x0000003fL) << 16;$ ERROR: code indent should never use tabs #762: FILE: crypto/desrfb.c:118: + *cook^I|= (*raw1 & 0x0003f000L) >> 4;$ ERROR: space prohibited after that open parenthesis '(' #779: FILE: crypto/desrfb.c:130: + while( to < endp ) *to++ = *from++; ERROR: space prohibited before that close parenthesis ')' #779: FILE: crypto/desrfb.c:130: + while( to < endp ) *to++ = *from++; ERROR: space required before the open parenthesis '(' #779: FILE: crypto/desrfb.c:130: + while( to < endp ) *to++ = *from++; ERROR: trailing statements should be on next line #779: FILE: crypto/desrfb.c:130: + while( to < endp ) *to++ = *from++; ERROR: braces {} are necessary for all arms of this statement #779: FILE: crypto/desrfb.c:130: + while( to < endp ) *to++ = *from++; [...] ERROR: code indent should never use tabs #811: FILE: crypto/desrfb.c:146: + *into^I = (*outof++ & 0xffL) << 24;$ ERROR: code indent should never use tabs #812: FILE: crypto/desrfb.c:147: + *into^I|= (*outof++ & 0xffL) << 16;$ ERROR: code indent should never use tabs #813: FILE: crypto/desrfb.c:148: + *into^I|= (*outof++ & 0xffL) << 8;$ ERROR: code indent should never use tabs #815: FILE: crypto/desrfb.c:150: + *into^I = (*outof++ & 0xffL) << 24;$ ERROR: code indent should never use tabs #816: FILE: crypto/desrfb.c:151: + *into^I|= (*outof++ & 0xffL) << 16;$ ERROR: code indent should never use tabs #817: FILE: crypto/desrfb.c:152: + *into^I|= (*outof++ & 0xffL) << 8;$ ERROR: code indent should never use tabs #818: FILE: crypto/desrfb.c:153: + *into^I|= (*outof & 0xffL);$ ERROR: code indent should never use tabs #837: FILE: crypto/desrfb.c:162: + *into++ = (unsigned char)(*outof++^I & 0xffL);$ ERROR: code indent should never use tabs #841: FILE: crypto/desrfb.c:166: + *into^I= (unsigned char)(*outof^I & 0xffL);$ ERROR: space prohibited after that open parenthesis '(' #1189: FILE: crypto/desrfb.c:339: + for( round = 0; round < 8; round++ ) { ERROR: space prohibited before that close parenthesis ')' #1189: FILE: crypto/desrfb.c:339: + for( round = 0; round < 8; round++ ) { ERROR: space required before the open parenthesis '(' #1189: FILE: crypto/desrfb.c:339: + for( round = 0; round < 8; round++ ) { ERROR: code indent should never use tabs #1192: FILE: crypto/desrfb.c:342: + fval = SP7[ work^I^I & 0x3fL];$ ERROR: space prohibited after that open square bracket '[' #1192: FILE: crypto/desrfb.c:342: + fval = SP7[ work & 0x3fL]; ERROR: code indent should never use tabs #1197: FILE: crypto/desrfb.c:347: + fval |= SP8[ work^I^I & 0x3fL];$ ERROR: space prohibited after that open square bracket '[' #1197: FILE: crypto/desrfb.c:347: + fval |= SP8[ work & 0x3fL]; ERROR: code indent should never use tabs #1204: FILE: crypto/desrfb.c:354: + fval = SP7[ work^I^I & 0x3fL];$ ERROR: space prohibited after that open square bracket '[' #1204: FILE: crypto/desrfb.c:354: + fval = SP7[ work & 0x3fL]; ERROR: code indent should never use tabs #1209: FILE: crypto/desrfb.c:359: + fval |= SP8[ work^I^I & 0x3fL];$ ERROR: space prohibited after that open square bracket '[' #1209: FILE: crypto/desrfb.c:359: + fval |= SP8[ work & 0x3fL]; total: 146 errors, 0 warnings, 1232 lines checked Commit 99bac12da503 (crypto: finish removing TABs) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20181217231639.24250-1-pbonz...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com