Eric Blake <ebl...@redhat.com> writes: > On 1/2/19 12:01 PM, Christophe Fergeau wrote: >> Adding Markus to cc: list, I forgot to do it when sending the patch. > > Also worth backporting via qemu-stable, now in cc. > >> >> Christophe >> >> On Wed, Jan 02, 2019 at 03:05:35PM +0100, Christophe Fergeau wrote: >>> commit 8bca4613 added support for %% in json strings when interpolating, >>> but in doing so, this broke handling of % when not interpolating as the >>> '%' is skipped in both cases. >>> This commit ensures we only try to handle %% when interpolating.
Impact? If you're unable to assess, could you give us at least a reproducer? >>> Signed-off-by: Christophe Fergeau <cferg...@redhat.com> >>> --- >>> qobject/json-parser.c | 10 ++++++---- >>> tests/check-qjson.c | 5 +++++ >>> 2 files changed, 11 insertions(+), 4 deletions(-) >>> > > Reviewed-by: Eric Blake <ebl...@redhat.com> Patch looks good to me, but I'd like us to improve the commit message.
