On 03/15/11 15:49, Anthony Liguori wrote: >> index f4e4741..dec9a76 100644 >> --- a/console.h >> +++ b/console.h >> @@ -189,6 +189,9 @@ void register_displaystate(DisplayState *ds); >> DisplayState *get_displaystate(void); >> DisplaySurface* qemu_create_displaysurface_from(int width, int >> height, int bpp, >> int linesize, >> uint8_t *data); >> +DisplaySurface* qemu_alloc_display(DisplaySurface *surface, int width, >> + int height, int linesize, >> + PixelFormat pf, int newflags); > > Is it really useful at all to return DisplaySurface? When I see a > return value of 'DisplaySurface *' and an alloc in the function name, I > assume this function allocates a display surface but it's really > allocating the framebuffer within a display surface.
I am not sure what is better here - if you have a better suggestion for the name, I am all open. The reason it turned out this way is that there are already other ways where the DisplaySurface itself can be allocated. Cheers, Jes
