On 19/12/18 16:52, Michael S. Tsirkin wrote: > On Wed, Dec 19, 2018 at 04:50:36PM +0800, Peter Xu wrote: >> Starting from QEMU 4.0, let's specify "split" as the default value for >> kernel-irqchip. >> >> So for QEMU>=4.0 we'll have: allowed=Y,required=N,split=Y >> for QEMU<=3.1 we'll have: allowed=Y,required=N,split=N >> (omitting all the "kernel_irqchip_" prefix) >> >> Note that this "split" is optional - we'll first try to enable split >> kernel irqchip, and we'll fall back to complete kernel irqchip if we >> found that the kernel capability is missing. >> >> Signed-off-by: Peter Xu <pet...@redhat.com> > > I'm split on this one ;) > On the one hand why not make pc and q35 are consistent here? > On the other hand we really should work to leave PC alone > as much as we can ... > > Paolo, what's your opinion?
The idea was to avoid bumping the minimal kernel version for PC, only for Q35. PC can still use split irqchip for security purposes, but only Q35 needs it for features. Paolo
