Peter Maydell <peter.mayd...@linaro.org> writes: > On Fri, 14 Dec 2018 at 12:31, Markus Armbruster <arm...@redhat.com> wrote: >> Peter Maydell <peter.mayd...@linaro.org> writes: >> > On Fri, 14 Dec 2018 at 06:29, Markus Armbruster <arm...@redhat.com> wrote: >> > I have to admit I never really understood what tweak >> > you wanted making to the commit message. I'm happy >> > to make it clearer: do you want to suggest a rewording? >> >> The commit message claims "(The only changes needed are that Linux's >> checkpatch.pl WARN() function takes an extra argument that ours does >> not.)" This isn't the case. You also dropped the kernel's "Networking >> with an initial /*" special case. > > The bit of the commit message you didn't quote says > "by backporting the relevant > parts of the Linux kernel's checkpatch.pl. (The only changes > needed are that Linux's checkpatch.pl WARN() function takes > an extra argument that ours does not.)" > > The networking special case is not a "relevant part", which > is why it's not in the patch. The bracketed statement applies > to the code in the patch, not any lumps of code in the > kernel's checkpatch that are not in the patch.
I understand you logic now. > Anyway, I've adjusted the commit message as you suggest. > > Since we seem to now have consensus on the checkpatch patch, > I'm going to put it into the "misc" pull request I'm putting > together. Thanks!
