On Thu, Dec 13, 2018 at 09:03:23PM +0100, Thomas Huth wrote:
> On 2018-12-13 13:42, Kashyap Chamarthy wrote:
> > Also fix the wrong spelling of it: s/cpu-add/cpu_add/
> >
> > Signed-off-by: Kashyap Chamarthy <kcham...@redhat.com>
> > ---
> > qemu-deprecated.texi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
> > index 46bec688db..79743ab8bd 100644
> > --- a/qemu-deprecated.texi
> > +++ b/qemu-deprecated.texi
> > @@ -121,9 +121,9 @@ replaced by the ``target'' output member.
> > The @option{[hub_id name]} parameter tuple of the 'hostfwd_add' and
> > 'hostfwd_remove' HMP commands has been replaced by @option{netdev_id}.
> >
> > -@subsection cpu-add (since 3.1)
> > +@subsection cpu_add (since 4.0)
> >
> > -Use ``device_add'' for hotplugging vCPUs instead of ``cpu-add''. See
> > +Use ``device_add'' for hotplugging vCPUs instead of ``cpu_add''. See
>
> AFAIK the spelling was right. It's "cpu-add" ... only device_add is
> using the underscore. Welcome to the wonderful world of QEMU
> inconsistencies...
Huh...I thought I checked the HMP spelling; but indeed you're right!
Confusingly enough, the QMP spelling _doesn't_ have underscore:
[...]
ETEXI
{
.name = "cpu-add",
.args_type = "id:i",
.params = "id",
.help = "add cpu (deprecated, use device_add instead)",
.cmd = hmp_cpu_add,
},
STEXI
@item cpu-add @var{id}
@findex cpu-add
Add CPU with id @var{id}. This command is deprecated, please
+use @code{device_add} instead. For details, refer to
'docs/cpu-hotplug.rst'.
[...]
Thanks for the eagle eyes, Thomas.
--
/kashyap
