On Wed, Dec 12, 2018 at 05:17:26PM +0530, P J P wrote: > From: Prasad J Pandit <p...@fedoraproject.org> > > Replace VENDOR_ERR_NO_SGE macro with VENDOR_ERR_INV_NUM_SGE > to indicate invalid number of scatter/gather elements.
Suggesting a revised commit message such as: With commit xxxx ("pvrdma: check number of pages when creating rings") VENDOR_ERR_NO_SGE is no longer in use - delete it. (kinda ambiguity if subject says "remove" while commit message says "replace") > > Signed-off-by: Prasad J Pandit <p...@fedoraproject.org> > --- > hw/rdma/rdma_backend.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c > index bd4710d16f..c28bfbd44d 100644 > --- a/hw/rdma/rdma_backend.c > +++ b/hw/rdma/rdma_backend.c > @@ -37,12 +37,11 @@ > #define VENDOR_ERR_TOO_MANY_SGES 0x202 > #define VENDOR_ERR_NOMEM 0x203 > #define VENDOR_ERR_QP0 0x204 > -#define VENDOR_ERR_NO_SGE 0x205 > +#define VENDOR_ERR_INV_NUM_SGE 0x205 > #define VENDOR_ERR_MAD_SEND 0x206 > #define VENDOR_ERR_INVLKEY 0x207 > #define VENDOR_ERR_MR_SMALL 0x208 > #define VENDOR_ERR_INV_MAD_BUFF 0x209 > -#define VENDOR_ERR_INV_NUM_SGE 0x210 > > #define THR_NAME_LEN 16 > #define THR_POLL_TO 5000 > -- > 2.19.2 >