On 12/7/18 11:28 AM, Eric Blake wrote:
> On 12/6/18 1:25 PM, John Snow wrote:
>> The 'x' prefix was added because we were uncertain of the direction we'd
>> take for the libvirt API. With the general approach solidified, I feel
>> comfortable committing to this API for 4.0.
>>
>> Signed-off-by: John Snow <js...@redhat.com>
>> ---
>
>> +++ b/tests/qemu-iotests/223
>> @@ -112,9 +112,9 @@ _send_qemu_cmd $QEMU_HANDLE
>> '{"execute":"qmp_capabilities"}' "return"
>> _send_qemu_cmd $QEMU_HANDLE '{"execute":"blockdev-add",
>> "arguments":{"driver":"qcow2", "node-name":"n",
>> "file":{"driver":"file", "filename":"'"$TEST_IMG"'"}}}' "return"
>> -_send_qemu_cmd $QEMU_HANDLE '{"execute":"x-block-dirty-bitmap-disable",
>> +_send_qemu_cmd $QEMU_HANDLE '{"execute":"block-dirty-bitmap-disable",
>> "arguments":{"node":"n", "name":"b"}}' "return"
>> -_send_qemu_cmd $QEMU_HANDLE '{"execute":"x-block-dirty-bitmap-disable",
>> +_send_qemu_cmd $QEMU_HANDLE '{"execute":"block-dirty-bitmap-disable",
>> "arguments":{"node":"n", "name":"b2"}}' "return"
>> _send_qemu_cmd $QEMU_HANDLE '{"execute":"nbd-server-start",
>> "arguments":{"addr":{"type":"unix",
>
> No iotests coverage of block-dirty-bitmap-merge. We should fix that as
> part of this series; separate patch is fine.
>
you're not wrong :(
> I'm glad you remembered to renumber all the 'since' tags to 4.0 (as the
> new spelling is indeed new to 4.0, not when we introduced the older x-
> variant).
>
> Reviewed-by: Eric Blake <ebl...@redhat.com>
>
Thanks!
