Hello Yuval, +-- On Tue, 11 Dec 2018, Yuval Shaia wrote --+ | > Ditto, here send rind and recv rings stays mapped. | > Look at how QP's ring is destroyed in destroy_qp. | > | > For both case suggesting to define a new static function that destroy rings | > and call it from both error flow of create_* and from destroy_* | >
I see, okay. Similar resource clean-up required in pvrdma_realize(). In case of an error it does: 'goto out;', but nothing is free'd there. Is another destroy_ routine required there? | Also, can you rebase this patch on top of the patchset i posted last week: | https://patchwork.kernel.org/patch/10705439/ Okay, I'll send revised patch set. Thanks so much for the prompt review. Thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
