Am 07.12.2018 um 07:40 hat Markus Armbruster geschrieben: > Kevin Wolf <kw...@redhat.com> writes: > > > From: Fam Zheng <f...@redhat.com> > > > > The extracted vmdk_init_extent takes a BlockBackend object and > > initializes the format metadata. It is the common part between "qemu-img > > create" and "blockdev-create". > > > > Add a "BlockBackend *pbb" parameter to vmdk_create_extent, to return the > > opened BB to the caller in the next patch. > > I'd do this part in the next patch, when it has a user. Matter of > taste.
I kept Fam as the author of the patches (except for the test case which is effectively a rewrite with Fam's test as the spec), so I'd like to do only the minimal editing necessary to make the patches mergeable. If it's a matter of taste, I'll leave it as it is. The same goes for code changes that are a matter of taste: If you _really_ care about taste in the vmdk code, feel free to send a follow-up and I'll merge it on top, but I'll leave Fam's patches alone as much as I can. > Reviewed-by: Markus Armbruster <arm...@redhat.com> Thanks! Kevin
